Re: [PATCH net-next] tc: cls_bpf: make ingress and egress qdiscs consistent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Alexei Starovoitov <ast@xxxxxxxxxxxx>
Date: Fri,  3 Apr 2015 14:16:24 -0700

> +		if (skb_headroom(skb) < ETH_HLEN)
> +			return -1;
> +		__skb_push(skb, ETH_HLEN);
 ...
> +	if (tp->q->flags & TCQ_F_INGRESS)
> +		__skb_pull(skb, ETH_HLEN);

Please use the actual device's L2 header length, via
dev->hard_header_len, rather than hard coding ethernet.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux