On 03/27/2015 01:04 AM, Daniel Vetter wrote: > On Fri, Mar 27, 2015 at 08:39:56AM +0200, Jani Nikula wrote: >> On Thu, 26 Mar 2015, Tommi Rantala <tt.rantala@xxxxxxxxx> wrote: >>> Fix definition of the DRM_IOCTL_I915_GET_SPRITE_COLORKEY ioctl, so that it >>> is different from the DRM_IOCTL_I915_SET_SPRITE_COLORKEY ioctl. >>> >>> Signed-off-by: Tommi Rantala <tt.rantala@xxxxxxxxx> >> >> Whoa. Broken since its introduction in >> >> commit 8ea30864229e54b01ac0e9fe88c4b733a940ec4e >> Author: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> >> Date: Tue Jan 3 08:05:39 2012 -0800 >> >> drm/i915: add color key support v4 >> >> Cc: stable@xxxxxxxxxxxxxxx > > Nope, we'll just rip it out and replace it all with the drm_noop ioctl. At > least I didn't find any userspace anywhere and only broken definitions. > Proof enough this isn't useful. > > Even more so since that means we don't have to convert the get ioctl over > to atomic, yay! I'll send patches. Can we just skip the noop part and delete it altogether? It was only added speculatively and obviously never used at all... -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
