On 23/03/15 22:05, Srinivas Kandagatla wrote:
On 23/03/15 21:09, Mark Brown wrote:
On Fri, Mar 13, 2015 at 09:50:14AM +0000, Srinivas Kandagatla wrote:
A couple of *very* minor points below, otherwise this looks OK to me.
Thankyou for the review.
+struct eeprom_device *eeprom_register(struct eeprom_config *config)
+{
+ struct eeprom_device *eeprom;
+ int rval;
+
+ if (!config->regmap || !config->size) {
+ dev_err(config->dev, "Regmap not found\n");
+ return ERR_PTR(-EINVAL);
+ }
You have a struct device in the config and the regmap API has
dev_get_regmap() which for most devices that don't have multiple regmaps
will give the right regmap. It would be nice to support this as a
convenience for users.
Yes, sure that makes sense, I will give it a try.
I did try your suggestion, by which I could remove the regmap from
config. One thing I did not like was eeprom-core getting size/stride
info directly from providers and regmap from regmap apis. I was
wondering if we could take a step further and introduce new regmap
helpers like
regmap_get_size(regmap)
regmap_get_stride(regmap)
Which would be give eeprom-core the size and stride info, doing this way
would cut down regmap related things from eeprom_config structure to
minimal and also the source of information would come from just regmap apis.
--srini
+ eeprom = kzalloc(sizeof(*eeprom), GFP_KERNEL);
+ if (!eeprom)
+ return ERR_PTR(-ENOMEM);
...
+ rval = device_add(&eeprom->dev);
+ if (rval)
+ return ERR_PTR(rval);
Don't you need a kfree() if device_add() fails?
I will fix it in next version.
--srini
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
