Re: [PATCH v8 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/20/15 2:22 PM, Steven Rostedt wrote:
+/* limited trace_printk()
+ * only %d %u %x %ld %lu %lx %lld %llu %llx %p conversion specifiers allowed
+ */

Ah! Again, don't contaminate the rest of the kernel with net comment
styles! :-)

ok :)

+		} else if (fmt[i] == 'p') {
+			mod[fmt_cnt]++;
+			i++;
+			if (!isspace(fmt[i]) && fmt[i] != 0)

I wonder if we should allow punctuation here too? None alpha-numeric
characters?

yes. just checked all of ispunct characters after %p.
All should be fine.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux