On Fri, Mar 20, 2015 at 12:55 AM, <roy.qing.li@xxxxxxxxx> wrote: > From: Li RongQing <roy.qing.li@xxxxxxxxx> > > After 2f9783669 [ARM: 7412/1: audit: use only AUDIT_ARCH_ARM regardless > of endianness], no kernel user uses this macro; > > Keeping this macro, only makes the compiling old version audit [before > changeset 931 Improve ARM and AARCH64 support] success, but the audit > program can not work with the kernel after 2f9783669 still, > since no syscall entry is enabled for AUDIT_ARCH_ARMEB in kernel. > > so remove it to force to use the latest audit program > > Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx> > --- > other workaround is to define AUDIT_ARCH_ARMEB as AUDIT_ARCH_ARM, > but it seems very strange > > include/uapi/linux/audit.h | 1 - > 1 file changed, 1 deletion(-) Since this #define lives in the user visible headers I don't want to remove it and risk causing a userspace breakage. Leaving the #define in the header, even if it is unused by modern userspace, is harmless. > diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h > index d3475e1..125aa49 100644 > --- a/include/uapi/linux/audit.h > +++ b/include/uapi/linux/audit.h > @@ -351,7 +351,6 @@ enum { > #define AUDIT_ARCH_AARCH64 (EM_AARCH64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) > #define AUDIT_ARCH_ALPHA (EM_ALPHA|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE) > #define AUDIT_ARCH_ARM (EM_ARM|__AUDIT_ARCH_LE) > -#define AUDIT_ARCH_ARMEB (EM_ARM) > #define AUDIT_ARCH_CRIS (EM_CRIS|__AUDIT_ARCH_LE) > #define AUDIT_ARCH_FRV (EM_FRV) > #define AUDIT_ARCH_I386 (EM_386|__AUDIT_ARCH_LE) > -- > 2.1.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html