On Wed, 2015-03-18 at 12:05 -0600, Shuah Khan wrote: > Several tests that rely on implicit build rules fail to build, > when invoked from the main Makefile kselftest target. These > failures are due to --no-builtin-rules and --no-builtin-variables > options set in the inherited MAKEFLAGS. > > --no-builtin-rules eliminates the use of built-in implicit rules > and --no-builtin-variables is for not defining built-in variables. > These two options override the use of implicit rules resulting in > build failures. In addition, inherited LDFLAGS result in build > failures and there is no need to define LDFLAGS. Clear LDFLAGS > and MAKEFLAG when make is invoked from the main Makefile kselftest > target. Fixing this at selftests Makefile avoids changing the main > Makefile and keeps this change self contained at selftests level. Yep this looks good. Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> cheers -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
