On Tue, Mar 17, 2015 at 08:33:27AM -0700, Kees Cook wrote: > On Mon, Mar 16, 2015 at 4:24 PM, Dave Chinner > <david@xxxxxxxxxxxxx> wrote: > > On Mon, Mar 09, 2015 at 02:00:11PM +0000, David Drysdale wrote: > >> Test basic openat(2) behaviour. > >> > >> Test that if O_BENEATH flag is set, openat() will only open > >> paths that have no .. component and do not start with /. > >> Symlinks are also checked for the same restrictions. > >> > >> Signed-off-by: David Drysdale <drysdale@xxxxxxxxxx> --- > >> .gitignore | 1 + common/openat | 61 > >> ++++++++++++++++++++++++++++++ src/Makefile | 3 +- > >> src/openat.c | 100 > >> +++++++++++++++++++++++++++++++++++++++++++++++++ > > > > This strikes me as something that shoul dbe added to xfs_io for > > testing, as it already supports a heap of other open flags and > > xfstests is already dependent on it. > > While I don't see a problem adding this to xfs_io, I'd still like > to see this test live in the kernel tree too. You can do whatever you want with the kernel tree - it doesn't concern me at all. > Having it in the > same source means more testing, IMO. That's complete bunk, though. This helper binary is a limited use, one shot test that can't be combined with anything else. "sharing" the source code across multiple different test suites doesn't change that. However, putting support into xfs_io means it will get more testing because we can *easily* use the functionality in many, many different ways. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
