On Wed, 2015-03-11 at 07:18 -0600, Shuah Khan wrote: > On 03/10/2015 10:06 PM, Michael Ellerman wrote: > > This adds make install support to selftests. The basic usage is: > > > > $ cd tools/testing/selftests > > $ make install > > > > That installs into tools/testing/selftests/install, which can then be > > copied where ever necessary. > > > > The install destination is also configurable using eg: > > > > $ INSTALL_PATH=/mnt/selftests make install > > > > The implementation uses two targets in the child makefiles. The first > > "install" is expected to install all files into $(INSTALL_PATH). > > > > The second, "emit_tests", is expected to emit the test instructions (ie. > > bash script) on stdout. Separating this from install means the child > > makefiles need no knowledge of the location of the test script. > > > > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > > --- > > > > v3: Rebase onto 4.0-rc2. > > Rename all.sh to run_kselftest.sh. > > Add --no-print-directory to emit_tests invocation. > > v4: Rebase onto 4.0-rc3, add TEST_FILES to efivars and vm tests, remove > > newlines from echoes. > > I don't see my comments addressed. If you want me to take > this work, please address the following comments: > > - Name install directory kselftest. It should work with the > the use-case. > > make INSTALL_PATH=/tmp make install > The install directory should be /tmp/kselftest > > - Flatten the directory with all tests under /tmp/kselftest > > I am wasting lot of time because you don't fully address my > comments and send patches that dont' work correctly. Please > make sure your patches don't generate work for me. You're wasting a lot of time? You have got to be kidding me. You are wasting a lot of *my* time. You have my patches, they're signed off, you can do what you wish with them. Good luck. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
