At Wed, 11 Mar 2015 03:22:04 +0200, Mikko Rapeli wrote: > > On Tue, Feb 17, 2015 at 07:27:38AM +0100, Takashi Iwai wrote: > > At Tue, 17 Feb 2015 00:05:44 +0100, > > Mikko Rapeli wrote: > > > > > > The DECLARE_BITMAP macro is not available in userspace headers. > > > Fixes userspace compile error: > > > error: expected specifier-qualifier-list before ‘DECLARE_BITMAP’ > > > > It's nonsense. This results in an incompatible structure, thus ABI > > would be broken completely (actually this will break the compile of > > ld10k1). > > None of the exported headers after 'make headers_install' have definition > of DECLARE_BITMAP macro. It is defined in include/linux/types.h which is > different from include/uapi/linux/types.h and missing this definition and > a few other things. > > One option would be add DECLARE_BITMAP macro to include/uapi/linux/types.h > and add include/linux/bitops.h to uapi. > > Thoughts? Are there any other headers like that? If this is the only one, leave it as is. The only program that reads this are some alsa-tools ones and they have already own DECLARE_BITMAP() definition. Adding the extra definition here will even break the compilation out of sudden. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
