On Tue, Feb 17, 2015 at 10:16:09AM +0100, Arnd Bergmann wrote: > On Tuesday 17 February 2015 00:05:37 Mikko Rapeli wrote: > > +#ifdef __KERNEL__ > > +/* already defined in userspace via stdlib.h */ > > typedef struct { > > unsigned long sig[_NSIG_WORDS]; > > } sigset_t; > > +#endif /* __KERNEL__ */ > > I'm not sure here: Is this structure always identical to the one > we see in user space? > > If not, we might want to rename the typedef to __kernel_sigset_t > instead and use that inside of the uapi headers. I was copying this ifdef from the struct sigaction part in the same file: #ifndef __KERNEL__ struct sigaction { __sighandler_t sa_handler; unsigned long sa_flags; #ifdef SA_RESTORER __sigrestore_t sa_restorer; #endif sigset_t sa_mask; /* mask last for extensibility */ }; #endif I assumed it had the same problems at some point. -Mikko -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html