On 03/10/2015 04:09 PM, Cyrill Gorcunov wrote: > On Tue, Mar 10, 2015 at 04:00:59PM -0600, Shuah Khan wrote: >> kcmp Makefile doesn't have an explicit build rule. As a result, >> kcmp build fails, when it is run from top level Makefile target >> kselftest. Without the explicit rule, make works only when it is >> run in the current directory or from selftests directory. Add an >> explicit build rule to fix the problem. In addition, build fails >> as it can't find kcmp.h. Fix it by passing CFLAGS. >> >> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> >> --- >> tools/testing/selftests/kcmp/Makefile | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile >> index ff0eefd..83383eb 100644 >> --- a/tools/testing/selftests/kcmp/Makefile >> +++ b/tools/testing/selftests/kcmp/Makefile >> @@ -1,7 +1,8 @@ >> CC := $(CROSS_COMPILE)$(CC) >> -CFLAGS += -I../../../../usr/include/ >> +CFLAGS += -I../../../../include/uapi -I../../../../usr/include/ >> >> -all: kcmp_test >> +all: >> + $(CC) $(CFLAGS) kcmp_test.c -o kcmp_test >> >> run_tests: all >> @./kcmp_test || echo "kcmp_test: [FAIL]" > > Ho Shuah! Thanks for looking into it. I've a small question -- > why kcmp_test prerequsite is dropped? As to me it should remain > here, except explicit build rule added. > Are you looking for something like this: all: kcmp_test kcmp_test: $(CC) $(CFLAGS) kcmp_test.c -o kcmp_test I just simplified it and removed the prerequsite. If you prefer, I can make the change to keep the prereq. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
