On 03/04/2015 03:41 AM, Michael Ellerman wrote: > There's no need to open-code the build rules, use the implicit ones. > > This has the nice side effect of enabling cross compilation. > > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > --- > tools/testing/selftests/mount/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mount/Makefile b/tools/testing/selftests/mount/Makefile > index a5b367f032ba..a6c62bedb0d9 100644 > --- a/tools/testing/selftests/mount/Makefile > +++ b/tools/testing/selftests/mount/Makefile > @@ -1,13 +1,13 @@ > # Makefile for mount selftests. > > -all: unprivileged-remount-test > +TEST_PROGS := unprivileged-remount-test > + > +CFLAGS += -O2 -Wall > > -unprivileged-remount-test: unprivileged-remount-test.c > - gcc -Wall -O2 unprivileged-remount-test.c -o unprivileged-remount-test > +all: $(TEST_PROGS) > > include ../lib.mk > > -TEST_PROGS := unprivileged-remount-test > override RUN_TESTS := if [ -f /proc/self/uid_map ] ; then ./unprivileged-remount-test ; fi > override EMIT_TESTS := echo "$(RUN_TESTS)" > Nack. This change breaks make kselftest run. Test fails to build. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
