On Fri, 2015-01-16 at 09:34 -0700, Shuah Khan wrote: > On 01/09/2015 02:06 AM, Michael Ellerman wrote: > > Add a new make target to install kernel selftests. This new target will > > build and install selftests. > > > > The default is just $(objtree)/selftests. This is preferable to > > something based on $(INSTALL_MOD_PATH) (which defaults to /), as it > > allows a normal user to install the tests. This is similar to the > > default behaviour of make headers_install. > > A normal user can install tests at any location they choose by > overriding the default path. For example: > > INSTALL_MOD_PATH=/tmp make kselftest_install > > will install under tmp. Why default to a directory that most users can't write to? That's not helpful. Users who are root can override the path, for example: INSTALL_MOD_PATH=/ make kselftest_install > The approach I used also ties test installs to kernel release. > This addresses an important use-case for kernel developers > that want to compare results from release to release. Sure, I'm happy to add the kernel release, so the default would be $(objtree)/selftests/$(kernel-release)/. > The use-case for any user to be able to install tests at > any location is addressed by the above example. The default should work for most users most of the time, / does not achieve that. > I would like these two above use-cases continued to be supported, > especially the one that tries the test installs to kernel release. That's fine, I'm happy to update this to use kernel release. But defaulting to / doesn't make sense. > Another goal is to keep changes to the main Makefile minimal and > the rest of the install support belongs under selftests/Makefile > and any other include file (like the one you proposed). Yes, this patch does just that. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
