On 01/09/2015 02:06 AM, Michael Ellerman wrote: Missing commit log. Please make sure your future include a meaningful commit log that describes what the patch does. > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > --- > tools/testing/selftests/efivarfs/Makefile | 1 - > tools/testing/selftests/exec/Makefile | 1 - > tools/testing/selftests/kcmp/Makefile | 1 - > tools/testing/selftests/lib.mk | 6 ++++++ > tools/testing/selftests/net/Makefile | 1 - > tools/testing/selftests/powerpc/Makefile | 3 +-- > tools/testing/selftests/size/Makefile | 2 -- > tools/testing/selftests/vm/Makefile | 1 - > 8 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/tools/testing/selftests/efivarfs/Makefile b/tools/testing/selftests/efivarfs/Makefile > index 3052d0bda24b..d683486a859b 100644 > --- a/tools/testing/selftests/efivarfs/Makefile > +++ b/tools/testing/selftests/efivarfs/Makefile > @@ -1,4 +1,3 @@ > -CC = $(CROSS_COMPILE)gcc > CFLAGS = -Wall > > test_objs = open-unlink create-read > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index 886cabe307b1..4edb7d0da29b 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -1,4 +1,3 @@ > -CC = $(CROSS_COMPILE)gcc > CFLAGS = -Wall > BINARIES = execveat > DEPS = execveat.symlink execveat.denatured script subdir > diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile > index 0eecd183058c..2ae7450a9a89 100644 > --- a/tools/testing/selftests/kcmp/Makefile > +++ b/tools/testing/selftests/kcmp/Makefile > @@ -1,4 +1,3 @@ > -CC := $(CROSS_COMPILE)$(CC) > CFLAGS += -I../../../../usr/include/ > > all: kcmp_test > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 7bd3dabe2846..abae16396c43 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -1,3 +1,9 @@ > +# When we're called from kbuild $(CC) already contains $(CROSS_COMPILE), so > +# here we need to use "cc", otherwise we'll get $(CROSS_COMPILE) twice. The > +# only downside is it breaks someone overriding $(CC), but that's probably OK, > +# they can probably cope by changing their path. I don't want to see the compiles broken and users needing to work-around. Pleas find a way to not break the compiles. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
