On Fri, Jan 16, 2015 at 10:00:09AM +0000, Chunyan Zhang wrote:
> From: Zhizhou Zhang <zhizhou.zhang@xxxxxxxxxxxxxx>
>
> Adds the device tree support for Spreadtrum SC9836 SoC which is based on
> Sharkl64 platform.
>
> Sharkl64 platform contains the common nodes of Spreadtrum's arm64-based SoCs.
>
> Signed-off-by: Zhizhou Zhang <zhizhou.zhang@xxxxxxxxxxxxxx>
> Signed-off-by: Orson Zhai <orson.zhai@xxxxxxxxxxxxxx>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/Makefile | 1 +
> arch/arm64/boot/dts/sprd/Makefile | 5 ++
> arch/arm64/boot/dts/sprd/sc9836-openphone.dts | 49 +++++++++++++++++
> arch/arm64/boot/dts/sprd/sc9836.dtsi | 73 +++++++++++++++++++++++++
> arch/arm64/boot/dts/sprd/sharkl64.dtsi | 67 +++++++++++++++++++++++
> 5 files changed, 195 insertions(+)
> create mode 100644 arch/arm64/boot/dts/sprd/Makefile
> create mode 100644 arch/arm64/boot/dts/sprd/sc9836-openphone.dts
> create mode 100644 arch/arm64/boot/dts/sprd/sc9836.dtsi
> create mode 100644 arch/arm64/boot/dts/sprd/sharkl64.dtsi
[...]
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53", "arm,armv8";
> + reg = <0x0 0x0>;
> + enable-method = "psci";
> + };
> +
> + cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53", "arm,armv8";
> + reg = <0x0 0x1>;
> + enable-method = "psci";
> + };
> +
> + cpu@2 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53", "arm,armv8";
> + reg = <0x0 0x2>;
> + enable-method = "psci";
> + };
> +
> + cpu@3 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53", "arm,armv8";
> + reg = <0x0 0x3>;
> + enable-method = "psci";
> + };
> + };
Just to check, all CPUs may be hotplugged off and on, yes?
Including CPU0?
How is your implementation tested?
You boot CPUs at EL2?
> +
> + gic: interrupt-controller@12001000 {
> + compatible = "arm,gic-400";
> + #interrupt-cells = <3>;
> + interrupt-controller;
> + reg = <0 0x12001000 0 0x1000>,
> + <0 0x12002000 0 0x2000>,
> + <0 0x12004000 0 0x2000>,
> + <0 0x12006000 0 0x2000>;
> + };
You're missing the maintenance interrupt here.
[...]
> diff --git a/arch/arm64/boot/dts/sprd/sharkl64.dtsi b/arch/arm64/boot/dts/sprd/sharkl64.dtsi
> new file mode 100644
> index 0000000..b08989d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/sprd/sharkl64.dtsi
> @@ -0,0 +1,67 @@
> +/*
> + * Spreadtrum Sharkl64 platform DTS file
> + *
> + * Copyright (C) 2014, Spreadtrum Communications Inc.
> + *
> + * This file is licensed under a dual GPLv2 or X11 license.
> + */
> +
> +/ {
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + soc {
> + compatible = "simple-bus";
> + reg = <0x0 0x0 0x0 0x80000000>;
What is this reg for? It's not required by simple-bus.
If you want to encode that this covers a particular portion of the
address space, do so with the ranges proeprty.
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ap_apb: apb@70000000 {
> + compatible = "simple-bus";
> + reg = <0x0 0x70000000 0x0 0x10000000>;
Likewise here.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
