Hi, On Jan 11 2015 or thereabouts, Dmitry Torokhov wrote: > Hi Gabriel, > > On Sat, Jan 10, 2015 at 01:43:34PM +0100, Gabriel Laskar wrote: > > Ioctls numbers for UI_GET_SYSNAME and UI_GET_VERSION are incorrectly numbered, > > since nr number is 8bit encoded, 300 and 301 will effectively get 44 and 45. > > these two patches fixes this > > > > Nice catch, thank you! I folded the patches together (as they are fixing > essentially the same thing) , changed hex to dec (because the rest of > ioctls in uinput use decimal) and applied. > > I wonder if we need to put a BUILD_BUG_ON in one if _IO* defines to > catch such errors early on. > As others said, nice catch, thanks a lot. I feel very embarrassed about this :( Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
