On 12/03/2014 05:09 AM, Michal Marek wrote: > On 2014-12-01 17:39, Shuah Khan wrote: >> On 12/01/2014 08:47 AM, Michal Marek wrote: >>> On 2014-11-11 21:27, Shuah Khan wrote: >>>> diff --git a/Makefile b/Makefile >>>> index 05d67af..ccbd2e1 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -1071,12 +1071,26 @@ headers_check: headers_install >>>> $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1 >>>> >>>> # --------------------------------------------------------------------------- >>>> -# Kernel selftest >>>> +# Kernel selftest targets >>>> + >>>> +PHONY += __kselftest_configure >>>> +INSTALL_KSFT_PATH=$(INSTALL_MOD_PATH)/lib/kselftest/$(KERNELRELEASE) >>>> +export INSTALL_KSFT_PATH >>>> +KSELFTEST=$(INSTALL_KSFT_PATH)/kselftest.sh >>>> +export KSELFTEST >>> >>> Can this be moved to tools/testing/selftests/Makefile? It's only used in >>> this part of the tree. >> >> I looked into doing that. KERNELRELEASE will have to be exported for >> tools/testing/selftests/Makefile to use it? Does that sound okay? > > In fact, KERNELRELEASE is already exported. So go ahead. Good. > > >> Also, it might be easier to get this series in, if you can Ack the main >> Makefile patch (when we are ready i.e), so I can take it through >> kselftest tree. > > Sure. The Makefile change will only consist of redirecting the > kselftest_install target to tools/testing/selftests, right? > Correct. I plan to keep the selftests specific work under the selftests related Makefiles. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
