Hi, On Wed, Dec 03, 2014 at 12:21:07AM +0100, Peter Hüwe wrote: > --- a/drivers/char/tpm/tpm_i2c_nuvoton.c > +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c > @@ -605,10 +605,8 @@ static int i2c_nuvoton_probe(struct i2c_client *client, > return -ENODEV; > > rc = tpm_chip_register(chip); > - if (rc) > - return rc; > > - return 0; > + return rc; Maybe just return tpm_chip_register(chip)? A. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html