Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/2014 02:14 AM, Cyrill Gorcunov wrote:
> On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
>> On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
>>> --- a/include/linux/kcmp.h
>>> +++ b/include/linux/kcmp.h
>>> @@ -1,17 +1,6 @@
>>>  #ifndef _LINUX_KCMP_H
>>>  #define _LINUX_KCMP_H
>>>  
>>> -/* Comparison type */
>>> -enum kcmp_type {
>>> -       KCMP_FILE,
>>> -       KCMP_VM,
>>> -       KCMP_FILES,
>>> -       KCMP_FS,
>>> -       KCMP_SIGHAND,
>>> -       KCMP_IO,
>>> -       KCMP_SYSVSEM,
>>> -
>>> -       KCMP_TYPES,
>>> -};
>>> +#include <uapi/linux/kcmp.h>
>>>  
>>>  #endif /* _LINUX_KCMP_H */
>>>
>>
>> If the file is empty except for the uapi include, I think it's better to
>> delete it completely. The include path logic should ensure we pick the
>> other one up.
> 
> Good point, somehow managed to miss this.
> 

Michael,

Are you planning to send v2 to address the comments?

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux