On Tue, 25 Nov 2014 23:38:23 +0200
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> On Tue, Nov 25, 2014 at 06:48:11PM +0100, Cornelia Huck wrote:
> > On Tue, 25 Nov 2014 18:42:01 +0200
> > "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> >
> > > set FEATURES_OK as per virtio 1.0 spec
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > > ---
> > > include/uapi/linux/virtio_config.h | 2 ++
> > > drivers/virtio/virtio.c | 29 ++++++++++++++++++++++-------
> > > 2 files changed, 24 insertions(+), 7 deletions(-)
> > >
> >
> > > + if (virtio_has_feature(dev, VIRTIO_F_VERSION_1)) {
> > > + add_status(dev, VIRTIO_CONFIG_S_FEATURES_OK);
> > > + status = dev->config->get_status(dev);
> > > + if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) {
> > > + printk(KERN_ERR "virtio: device refuses features: %x\n",
> > > + status);
> >
> > Can you use dev_err() to include the information which device failed?
>
> I'm not sure - is dev_err OK to use from probe?
The dev_* functions should be fine anytime, but the driver has already
been set before ->probe is called anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
