On Mon, Nov 24, 2014 at 5:06 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Mon, Nov 24, 2014 at 11:53:56AM +0000, David Drysdale wrote: >> Hook up x86-64, i386 and x32 ABIs. >> >> Signed-off-by: David Drysdale <drysdale@xxxxxxxxxx> > > This one has been breaking my linux-next build for the past week. I'm > not sure what's going on. Hi Dan, Sorry if this has been causing you problems -- I've not had any errors from the kbuild robots or my local builds. > I build with a script: > > make allmodconfig > > cat << EOF >> .config > CONFIG_DYNAMIC_DEBUG=n > CONFIG_DEBUG_STRICT_USER_COPY_CHECKS=n > CONFIG_DYNAMIC_DEBUG=y > EOF > > make oldconfig > > Here are the errors: > > CHK include/generated/compile.h > CHECK arch/x86/ia32/audit.c > CC arch/x86/ia32/audit.o > arch/x86/ia32/audit.c: In function ‘ia32_classify_syscall’: > arch/x86/ia32/audit.c:38:7: error: ‘__NR_execveat’ undeclared (first use in this function) > arch/x86/ia32/audit.c:38:7: note: each undeclared identifier is reported only once for each function it appears in > make[2]: *** [arch/x86/ia32/audit.o] Error 1 > make[2]: Target `__build' not remade because of errors. > make[1]: *** [arch/x86/ia32] Error 2 > CHECK arch/x86/kernel/audit_64.c > CHK kernel/config_data.h > CC arch/x86/kernel/audit_64.o > arch/x86/kernel/audit_64.c: In function ‘audit_classify_syscall’: > arch/x86/kernel/audit_64.c:53:7: error: ‘__NR_execveat’ undeclared (first use in this function) > arch/x86/kernel/audit_64.c:53:7: note: each undeclared identifier is reported only once for each function it appears in > make[2]: *** [arch/x86/kernel/audit_64.o] Error 1 > make[2]: Target `__build' not remade because of errors. > make[1]: *** [arch/x86/kernel] Error 2 > make[1]: Target `__build' not remade because of errors. That seems odd -- the generic definition of __NR_execveat is in the first patch in the series, and the various x86-specific definitions should get generated from the table entries in the second patch in the series (at least since the v9 set I sent on 19 Nov, which split out the x86 wiring from the general implementation). Are the syscall table generation steps happening in your build? And does __NR_execveat appear in the various generated x86 unistd*.h headers? As an aside, I've just built next-20141124 (a4cfa44aa26a) fine from scratch with your config steps. The build output included the header generation steps: SYSTBL arch/x86/syscalls/../include/generated/asm/syscalls_32.h SYSHDR arch/x86/syscalls/../include/generated/asm/unistd_32_ia32.h SYSHDR arch/x86/syscalls/../include/generated/asm/unistd_64_x32.h SYSTBL arch/x86/syscalls/../include/generated/asm/syscalls_64.h SYSHDR arch/x86/syscalls/../include/generated/uapi/asm/unistd_32.h HOSTCC scripts/basic/bin2c SYSHDR arch/x86/syscalls/../include/generated/uapi/asm/unistd_64.h SYSHDR arch/x86/syscalls/../include/generated/uapi/asm/unistd_x32.h and the resulting files did include the __NR_execveat constant: % grep execveat usr/include/asm*/*.h arch/x86/include/generated/uapi/asm/*.h usr/include/asm-generic/unistd.h:#define __NR_execveat 281 usr/include/asm-generic/unistd.h:__SC_COMP(__NR_execveat, sys_execveat, compat_sys_execveat) usr/include/asm/unistd_32.h:#define __NR_execveat 358 usr/include/asm/unistd_64.h:#define __NR_execveat 322 usr/include/asm/unistd_x32.h:#define __NR_execveat (__X32_SYSCALL_BIT + 545) arch/x86/include/generated/uapi/asm/unistd_32.h:#define __NR_execveat 358 arch/x86/include/generated/uapi/asm/unistd_64.h:#define __NR_execveat 322 arch/x86/include/generated/uapi/asm/unistd_x32.h:#define __NR_execveat (__X32_SYSCALL_BIT + 545) So I can't (yet) reproduce your problem I'm afraid... > regards, > dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
