Am Freitag, 21. November 2014, 10:31:31 schrieb Herbert Xu: Hi Herbert, > On Thu, Nov 20, 2014 at 05:08:42PM +0100, Stephan Mueller wrote: > > Am Donnerstag, 20. November 2014, 21:40:29 schrieb Herbert Xu: > > > > Hi Herbert, > > > > > On Thu, Nov 20, 2014 at 02:10:00PM +0100, Stephan Mueller wrote: > > > > What about the following > > > > > > > > if (p->cru_driver_name[0] > > > > If the driver name is not empty > > > > > > alg = crypto_alg_match(p, 1); > > > > Do an exact match using the driver name > > > > > > else > > > > > > > > alg = crypto_alg_match(p, 0); > > > > Otherise use the generic name for a fuzzy match. > > > > > If cru_driver_name is not empty then exact will never be used, no? > > > > If the code suggestion does not follow my words outlined above, I want my > > words to be considered ;-) > > > > Yet, I am unsure where the code deviates from my words. > > No I am asking how is this different from my patch? Sorry, I withdraw my comment. Your patch is good as is after rechecking crypto_alg_match. > > Cheers, -- Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html