Hi Michael, On 10/23/2014 01:07 AM, Michael Ellerman wrote: > Don't prevent the test building on non-x86. Just try and build it and > let the chips fall where they may. As a user of kcmp via CRIU on arm and arm64, thanks! > diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile > index 4f00c0524501..cda9cc4004c9 100644 > --- a/tools/testing/selftests/kcmp/Makefile > +++ b/tools/testing/selftests/kcmp/Makefile > @@ -1,21 +1,7 @@ > -uname_M := $(shell uname -m 2>/dev/null || echo not) > -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/) > -ifeq ($(ARCH),i386) > - ARCH := x86 > - CFLAGS := -DCONFIG_X86_32 -D__i386__ > -endif > -ifeq ($(ARCH),x86_64) > - ARCH := x86 > - CFLAGS := -DCONFIG_X86_64 -D__x86_64__ > -endif > CFLAGS += -I../../../../usr/include/ > > all: > -ifeq ($(ARCH),x86) > gcc $(CFLAGS) kcmp_test.c -o kcmp_test Not that this needs to be addressed in this patch, but this looks broken for cross compilation. It looks like some of the other selftests use: CC = $(CROSS_COMPILE)gcc But perhaps this should be set (and perhaps with ':=') once at the top level. Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
