On Mon, Oct 20, 2014 at 12:09:27AM +0300, Tomas Winkler wrote: > > > > Here the options are limited because misc_register already spawns > > KOBJ_ADD. Not much to do unless we would wipe the current use of > > misc driver completely. > > I would strongly recommend to drop the misc layer here, as tpm itself > can provide the needed abstraction for the devices. This is exactly what I'm going to do for v4 of the patch set and take the rtc subsystem as a guideline how to structure things in proper way. It is ABI break but if you look at the TPM1 sysfs attributes most of them haven't been ever machine readable anyway so I'll at least give it shot and a take the feedback. I'm fully aware that doing such thing is comparable to killing your own mother :) Past experiences of trying to do such thing [1] have not been succesful but on the other hand this is very different scenario and different user volumes. It would make sense to rip off all the "human-only" TPM1 attributes in the same round. I'm wondering what is the set of sysfs attributes is that TrouSerS is dependent of? I would suggest to leave that subset available and remove attributes such as 'pcrs' that breaks all the conventions. [1] http://lwn.net/Articles/172306/ /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
