On Thu, Sep 25, 2014 at 9:40 PM, David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Alexei Starovoitov <ast@xxxxxxxxxxxx> > Date: Sun, 21 Sep 2014 17:06:50 -0700 > >> +#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; }) > > Please do not hide program control flow inside of a macro. ok. I'm pretty sure it will be less readable, but I'll get rid off it. I'm assuming you considered my arguments about it here: https://lkml.org/lkml/2014/7/2/656 No problem. It's a minor thing. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html