On 09/17/2014 06:17 PM, Alexei Starovoitov wrote:
On Wed, Sep 17, 2014 at 12:16 AM, Daniel Borkmann <dborkman@xxxxxxxxxx> wrote:
That actually still doesn't answer my question why the test stub
cannot live in lib/test_bpf where we have our actual testing
framework for eBPF/BPF, also since you exactly only build test_stub.c
when TEST_BPF is enabled which is the Kconfig for lib/test_bpf.
multiple reasons:
1.
lib/test_bpf.c is a module, whereas test_stub.c is kernel builtin.
2.
I wasn't sure that reusing CONFIG_TEST_BPF for this
purpose was a good idea. May be it's better to introduce
CONFIG_BPF_VERIFIER_TEST_STUBS or something.
3.
kernel/bpf/test_stubs.c can be removed once real tracing
or socket use case is in.
Yes, please, lets go for point 3 at the very least.
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
