On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > On śro, 2014-08-27 at 14:52 +0100, Lee Jones wrote: > > On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > > > > > Add support for MAX77836 charger to the max14577 driver. The MAX77836 > > > charger is almost the same as 14577 model except: > > > - No dead-battery detection; > > > - Support for special charger (like in MAX77693); > > > - Support for DX over-voltage protection (like in MAX77693); > > > - Lower values of charging current (two times lower current for > > > slow/fast charge, much lower EOC current); > > > - Slightly different values in ChgTyp field of STATUS2 register. On > > > MAX14577 0x6 is reserved and 0x7 dead battery. On the MAX77836 the > > > 0x6 means special charger and 0x7 is reserved. Regardless of these > > > differences the driver maps them to one enum max14577_muic_charger_type. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > > Cc: Anton Vorontsov <anton@xxxxxxxxxx> > > > Cc: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> > > > Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx> > > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> > > > --- > > > drivers/power/Kconfig | 4 +- > > > drivers/power/max14577_charger.c | 77 +++++++++++++++++++++++++++++------- > > > include/linux/mfd/max14577-private.h | 54 ++++++++++++++++++------- > > > > Not quite so important here, but better to break these out too. We > > can arrange ourselves to that the set can go in together. Just make > > sure it's bisectable. > > Are you sure? This will result in a patch which adds some > code/symbols/defines used only by next (future) patch. Independent apply > of such patch still won't make any sense because there won't be any user > of this code. That's fine. I take in lots of patches which do nothing more than adds/updates infrastructure. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
