Re: [PATCH] mm: update the description for madvise_remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Jun 2014, Wang Sheng-Hui wrote:

> Patch to man-page.
> 
> [PATCH] madvise.2: update the description for MADV_REMOVE
> 
> Currently we have more filesystems supporting fallcate, e.g ext4/btrfs,
> which can response to MADV_REMOVE gracefully.
> 
> And if filesystems don't support fallocate, the return error would be
> EOPNOTSUPP, instead of ENOSYS.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>

Great, thanks!  This looks like it can be applied immediately and doesn't 
require us to wait for any kernel change.

Good catch with the return value.

> ---
>  man2/madvise.2 | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/man2/madvise.2 b/man2/madvise.2
> index 032ead7..4ce869c 100644
> --- a/man2/madvise.2
> +++ b/man2/madvise.2
> @@ -99,13 +99,9 @@ or zero-fill-on-demand pages for mappings
>  without an underlying file.
>  .TP
>  .BR MADV_REMOVE " (since Linux 2.6.16)"
> -Free up a given range of pages
> -and its associated backing store.
> -Currently,
> -.\" 2.6.18-rc5
> -only shmfs/tmpfs supports this; other filesystems return with the
> -error
> -.BR ENOSYS .
> +Free up a given range of pages and its associated backing store.
> +Filesystems that don't support fallocate will return error
> +.BR EOPNOTSUPP.
>  .\" Databases want to use this feature to drop a section of their
>  .\" bufferpool (shared memory segments) - without writing back to
>  .\" disk/swap space.  This feature is also useful for supporting
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux