On 04/23/2014 04:21 PM, Miklos Szeredi wrote: > On Sat, Apr 19, 2014 at 11:08 AM, Michael Kerrisk (man-pages) > <mtk.manpages@xxxxxxxxx> wrote: >> Hi Miklos, >> >>> The code changes are pushed to the git tree and the updated man page is below. >> >> Now that renameat2() is in 3.15, I've taken these changes. This had to be >> manually does, because I'd done some major reworking on the pages since you >> originally wrote your text. So, I may have injected some errors. >> >> I did a little light reworking of the text and added VERSIONS and >> CONFORMING TO pieces. I also added a couple of FIXMEs, to note points >> that will need to be updated once glibc support is (presumably) added. >> (Carlos, what's the usual process for triggering that sort of thing?) >> >> Could you please review the diff below (now against rename(2)). > > Looks okay. Thanks for checking it. > One comment on the current rename.2 page: > > #include <fcntl.h> /* Definition of AT_* constants */ > > AT_ constants are not used in renameat() hence this seems unneeded. I think you overlooked AT_FDCWD? (It is true though that that comment is boilerplate across the *at() pages, some of which have several AT_* constants.) > Not sure where the RENAME_ constants need to go once renameat2() is > added to glibc, possibly to <stdio.h> since they are closely related > to rename. Will you be prodding the glibc folks about this? Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
