Hi Xiaoyan, On Tue, May 22, 2012 at 10:34 PM, Zhang, Xiaoyan <xiaoyan.zhang@xxxxxxxxx> wrote: > From: Xiaoyan Zhang <xiaoyan.zhang@xxxxxxxxx> > > The Physical Presence Interface enables the OS and the BIOS to cooperate > and provides a simple and straightforward platform user experience for > administering the TPM without sacrificing security. > > Signed-off-by: Xiaoyan Zhang <xiaoyan.zhang@xxxxxxxxx> > --- > drivers/char/tpm/tpm.c | 462 ++++++++++++++++++++++++++++++++++++++++++++++++ > drivers/char/tpm/tpm.h | 18 ++ > 2 files changed, 480 insertions(+), 0 deletions(-) This code looks clean - my only suggestion would be to add an #ifdef CONFIG_ACPI around it so it compiles out on ppc. Kent -- IBM LTC Security -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html