On Wed, Sep 7, 2011 at 1:52 PM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote: > On 09/07/2011 06:30 PM, Paul Clements wrote: >> >> Could you name this as NBD_SET_FLAGS, as that's more consistent with >> what it's really doing? > > I named it differently intentionally, actually, because it should not use > the flags field from the network protocol as is. Also, "features" sounds > more like something that is optional, while unrecognized "flags" should > probably cause a failure. Alright, I can buy that argument -- I don't feel that strongly about it... This looks good to me, then. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
