On Tue, Feb 03, 2009 at 09:06:59AM -0800, H. Peter Anvin wrote: > Gerd Hoffmann wrote: > > H. Peter Anvin wrote: > >> akpm@xxxxxxxxxxxxxxxxxxxx wrote: > >>> This prototype has one problem though: On 32bit archs is the (64bit) > >>> offset argument unaligned, which the syscall ABI of several archs doesn't > >>> allow to do. At least s390 needs a wrapper in glibc to handle this. As > >>> we'll need a wrappers in glibc anyway I've decided to push problem to > >>> glibc entriely and use a syscall prototype which works without > >>> arch-specific wrappers inside the kernel: The offset argument is > >>> explicitly splitted into two 32bit values. > >> That rather sucks. It'd be cleaner to just shuffle the argument order. > > > > That was discussed too. Doesn't solve the problem that you need some > > wrap-o-magic in glibc (this time to swap arguments instead of splitting > > the offset). And is has the drawback that it is confusing to have > > different argument ordering at application and syscall level (think > > strace). Check the archives for the details. > > > > A pointer would help. > > I would say that different argument order in strace is a lot better than > having an argument completely mangled, which is what one gets with this > as proposed. > > All in all, I think it is WRONG to make sane architectures suffer for > what broken architectures have to do, and we should implement this the > sane way without any shuffling, splitting, or other braindamage. Disagree. What is better: having _one_ _common_ argument order in the syscall interface, or having architectures end up doing their own thing? Think about your strace argument - you're effectively requiring strace to know that on architecture X, the syscall argument order is X1, but on architecture Y, that same syscall has argument order Y1, and maybe architecture Z, it's again a different order Z1. That _adds_ complexity to strace - rather than having one ordering to deal with for a syscall, it now has three different random orders. That's completely insane. With one _common_ ordering, at least strace has the possibility of cleanly sorting it out. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
