On 01/27, Jonathan Corbet wrote: > > On Wed, 28 Jan 2009 04:14:39 +0100 > Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > > I'll try to make the patch tomorrow, but the problem is that I am not > > sure this is not too ugly. > > FWIW, I'm partway through a new attempt using bitops for f_flags, moving > FASYNC flag handling into fasync_helper(), and doing away with > additional locks altogether. I have to get past the publication > deadline before I can finish it, though. Great. I'd be happy to agree with another approach. But please don't forget it is not strictly necessary f_op->fasync() must use fasync_helper(). And we have users (pipe_rdwr_fasync) which call fasync_helper() twice. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html