Dimitri John Ledkov <dimitri.ledkov@xxxxxxxxxxxxx> writes: > On Fri, 24 Nov 2023 at 14:36, Dimitri John Ledkov > <dimitri.ledkov@xxxxxxxxxxxxx> wrote: >> >> On Fri, 24 Nov 2023 at 06:01, Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote: >> > >> > Dimitri John Ledkov <dimitri.ledkov@xxxxxxxxxxxxx> writes: >> > >> > > I was working on how linux-libc-dev headers are shipped in Ubuntu and >> > > stumbled upon seemingly unused and useless linux/a.out.h header. It >> > > seems like it is an accidental leftover at this point. >> > >> > How do you see that they are unused? > > When I did my code search the only and last remaining userspace code > that imports linux/a.out.h it is the objtool that is patched in these > patch series. > It is also vendored as copy in aboot tool, which has been patched in > many downstreams to use a.out.h instead of linux/a.out.h. It sounds like you have done your homework. Please just document (as you in your reply to me) in your cover letter or elsewhere in the changes so that it is clear that due diligence has been performed and userspace should not break with this change. [snip] > Was your search > https://codesearch.debian.net/search?q=linux%2Fa.out.h&literal=1&perpkg=1 > ? Pretty much. I didn't have the perpkg=1. Debian code search is the most comprehensive code search I am aware of so I took a quick look. Since it appears the only users are vendored versions of linux/a.out.h then it should be possible to make this change without breaking userspace. If it turns that is wrong the changes can be reverted. Eric
