Re: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 13 Sep 2023 21:00:11 -0400
Cc: Rob Herring <robh@xxxxxxxxxx>, Bjorn Helgaas <helgaas@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Brian King <brking@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 3chas3@xxxxxxxxx, dalias@xxxxxxxx, glaubitz@xxxxxxxxxxxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, kw@xxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, lpieralisi@xxxxxxxxxx, mattst88@xxxxxxxxx, netdev@xxxxxxxxxxxxxxx, richard.henderson@xxxxxxxxxx, toan@xxxxxxxxxxxxxxxxxxxxxx, ysato@xxxxxxxxxxxxx
In-reply-to: <20230911125354.25501-7-ilpo.jarvinen@linux.intel.com> ("Ilpo Järvinen"'s message of "Mon, 11 Sep 2023 15:53:54 +0300")
Organization: Oracle Corporation
References: <20230911125354.25501-1-ilpo.jarvinen@linux.intel.com> <20230911125354.25501-7-ilpo.jarvinen@linux.intel.com>

Ilpo,

> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>
> No functional changes intended.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling
  - From: Ilpo Järvinen
- [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line
  - From: Ilpo Järvinen

Prev by Date: Re: [PATCH 2/2] arch: Reserve map_shadow_stack() syscall number for all architectures
Next by Date: Re: [PATCH 2/2] arch: Reserve map_shadow_stack() syscall number for all architectures
Previous by thread: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line
Next by thread: Re: [PATCH v3 0/6] PCI/treewide: Cleanup/streamline PCI error code handling
Index(es):
- Date
- Thread

[Index of Archives] [Netdev] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]