On Wed, Oct 12, 2022, at 4:05 PM, Guenter Roeck wrote:
> On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote:
>> On Tue, Oct 4, 2022, at 9:42 PM, Guenter Roeck wrote:
>> > On 10/3/22 06:03, Arnd Bergmann wrote:
>> >> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote:
>> >
>> > Looks like something was missed. When building alpha:allnoconfig
>> > in next-20221004:
>> >
>> > Building alpha:allnoconfig ... failed
>> > --------------
>> > Error log:
>> > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> > arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for
>> > 'marvel_ioread8'; have 'unsigned int(const void *)'
>> > 807 | marvel_ioread8(const void __iomem *xaddr)
>> > | ^~~~~~~~~~~~~~
>> > In file included from arch/alpha/kernel/core_marvel.c:10:
>> > arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration
>> > of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned
>> > char(const void *)'}
>> > 335 | extern u8 marvel_ioread8(const void __iomem *);
>> > | ^~~~~~~~~~~~~~
>>
>> Right, I already noticed this and uploaded a fixed branch earlier today.
>> Should be ok tomorrow.
>>
>
> Unfortunately that did not completely fix the problem, or maybe the fix got
> lost. In mainline, when building alpha:allnoconfig:
>
> arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';',
> 'asm' or '__attribute__' before 'marvel_ioread8'
> 807 | marvel_ioread8(const void __iomem *xaddr)
>
> The code is:
>
> unsigned u8
> marvel_ioread8(const void __iomem *xaddr)
>
> The compiler doesn't like "unsigned u8".
Right, I fixed up a different bug and introduced this wrong type.
I didn't catch my mistake until after the pull request was
merged, but fixed it in
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=2e21c1575208
which should be in linux-next. I was giving it a little more
time to be see if there are any other regressions I caused.
Arnd
