On Mon, Oct 3, 2022 at 3:04 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > From 258382f3ca77b0e50501a0010d8c9abc2d4c51c8 Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@xxxxxxxx> > Date: Mon, 3 Oct 2022 13:12:54 +0200 > Subject: [PATCH] alpha: add full ioread64/iowrite64 implementation > > The previous patch introduced ioread64/iowrite64 declarations, but > this means we no longer get the io-64-nonatomic variant, and > run into a long error when someone actually wants to use these: > > ERROR: modpost: "ioread64" [drivers/net/ethernet/freescale/enetc/fsl-enetc.ko] undefined! > > Add the (hopefully) correct implementation for each machine type, > based on the 32-bit accessor. Since the 32-bit return type does > not work for ioread64(), change the internal implementation to use > the correct width consistently, but leave the external interface > to match the asm-generic/iomap.h header that uses 32-bit or 64-bit > return values. > > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Fixes: 7e772dad9913 ("alpha: Use generic <asm-generic/io.h>") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> This patch was really sweet for Alpha, it makes all of the code more complete and consistent. Yours, Linus Walleij