From: Xu Panda <xu.panda@xxxxxxxxxx> Do not use assignment in if condition, and comparing pointer whith NULL instead of comparing pointer to 0. Reported-by: Zeal Robot <zealci@xxxxxxxxxx> Signed-off-by: Xu Panda <xu.panda@xxxxxxxxxx> --- arch/alpha/mm/fault.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/alpha/mm/fault.c b/arch/alpha/mm/fault.c index ef427a6bdd1a..bb3fe2949313 100644 --- a/arch/alpha/mm/fault.c +++ b/arch/alpha/mm/fault.c @@ -194,7 +194,8 @@ do_page_fault(unsigned long address, unsigned long mmcsr, no_context: /* Are we prepared to handle this fault as an exception? */ - if ((fixup = search_exception_tables(regs->pc)) != 0) { + fixup = search_exception_tables(regs->pc); + if (fixup != NULL) { unsigned long newpc; newpc = fixup_exception(dpf_reg, fixup, regs->pc); regs->pc = newpc; -- 2.15.2