On Fri, Sep 02, 2022 at 06:07:31AM +0100, Al Viro wrote: > > With the asm even having a comment about how it only works because > > alpha doesn't do preemption (ARCH_NO_PREEMPT), but then the C code > > does do those preempt_disable/enable pairs, and I see an actual bug in > > there too: > > > > Both alpha_read_fp_reg() and alpha_read_fp_reg_s() do a > > preempt_enable() -> preempt_enable() pair (ie the first one should be > > a preempt_disable()). > > Will fix. Done and pushed. IIRC, that started as a similar comment re "we'd need to disable preemption here if we ever grow one on alpha", but I ended up looking at it and deciding that it's easier to just go ahead and call preempt_disable()/preempt_enable() instead of comments.
