Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
Subject: Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Fri, 11 Oct 2019 13:15:39 +0200
Cc: Michal Hocko <mhocko@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, rth@xxxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, mattst88@xxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, mpe@xxxxxxxxxxxxxx, heiko.carstens@xxxxxxxxxx, gor@xxxxxxxxxxxxx, borntraeger@xxxxxxxxxx, ysato@xxxxxxxxxxxxxxxxxxxx, dalias@xxxxxxxx, davem@xxxxxxxxxxxxx, ralf@xxxxxxxxxxxxxx, paul.burton@xxxxxxxx, jhogan@xxxxxxxxxx, jiaxun.yang@xxxxxxxxxxx, chenhc@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, rppt@xxxxxxxxxxxxx, anshuman.khandual@xxxxxxx, tglx@xxxxxxxxxxxxx, cai@xxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, x86@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, luto@xxxxxxxxxx, len.brown@xxxxxxxxx, axboe@xxxxxxxxx, dledford@xxxxxxxxxx, jeffrey.t.kirsher@xxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, naveen.n.rao@xxxxxxxxxxxxxxxxxx, mwb@xxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, tbogendoerfer@xxxxxxx, linux-mips@xxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6cc94f9b-0d79-93a8-5ec2-4f6c21639268@huawei.com>
References: <20190924124325.GQ2349@hirez.programming.kicks-ass.net> <20190924125936.GR2349@hirez.programming.kicks-ass.net> <20190924131939.GS23050@dhcp22.suse.cz> <1adcbe68-6753-3497-48a0-cc84ac503372@huawei.com> <20190925104108.GE4553@hirez.programming.kicks-ass.net> <47fa4cee-8528-7c23-c7de-7be1b65aa2ae@huawei.com> <bec80499-86d9-bf1f-df23-9044a8099992@arm.com> <a5f0fc80-8e88-b781-77ce-1213e5d62125@huawei.com> <20191010073212.GB18412@dhcp22.suse.cz> <6cc94f9b-0d79-93a8-5ec2-4f6c21639268@huawei.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Fri, Oct 11, 2019 at 11:27:54AM +0800, Yunsheng Lin wrote:
> But I failed to see why the above is related to making node_to_cpumask_map()
> NUMA_NO_NODE aware?

Your initial bug is for hns3, which is a PCI device, which really _MUST_
have a node assigned.

It not having one, is a straight up bug. We must not silently accept
NO_NODE there, ever.

Follow-Ups:
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Yunsheng Lin

References:
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Peter Zijlstra
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Peter Zijlstra
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Michal Hocko
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Yunsheng Lin
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Peter Zijlstra
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Yunsheng Lin
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Robin Murphy
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Yunsheng Lin
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Michal Hocko
- Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
  - From: Yunsheng Lin

Prev by Date: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note"
Next by Date: Re: [PATCH v2 02/29] powerpc: Remove PT_NOTE workaround
Previous by thread: Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
Next by thread: Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware
Index(es):
- Date
- Thread

[Index of Archives] [Netdev] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]