On Fri, Nov 02, 2018 at 08:56:37PM +0530, Brajeswar Ghosh wrote: > Remove asm/xchg.h which is included more than once > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@xxxxxxxxx> > --- > arch/alpha/include/asm/cmpxchg.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h > index 6c7c39452471..bcbdac0744f9 100644 > --- a/arch/alpha/include/asm/cmpxchg.h > +++ b/arch/alpha/include/asm/cmpxchg.h > @@ -36,7 +36,6 @@ > #undef ____cmpxchg > #define ____xchg(type, args...) __xchg ##type(args) > #define ____cmpxchg(type, args...) __cmpxchg ##type(args) > -#include <asm/xchg.h> It's amazing the number of times we get a patch to remove that. Instead of just automatically removing a second include of a header file, why don't you take a closer look to see what it actually does? Cheers, Michael.