Re: the patch "alpha/PCI: Replace pci_fixup_irqs()" breaks networking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 03, 2018 at 09:50:42PM +0200, Meelis Roos wrote:
> > I suspect we ought to map IRQs early in this platform so that we are
> > able to detect how platform code should set them up.
> 
> SIO is used in multiple alpha platforms - should this patch work on all 
> of them?

This patch does nothing but assigning the IRQ earlier, as I said
in another thread I will modify it to make it simpler and avoid
relying on pci_assign_irq() - it was just to understand if my
assumption was right.

Lorenzo

> > Thanks,
> > Lorenzo
> > 
> > -- >8 --
> > diff --git a/arch/alpha/kernel/sys_sio.c b/arch/alpha/kernel/sys_sio.c
> > index 37bd6d9b8eb9..407ab603e9b1 100644
> > --- a/arch/alpha/kernel/sys_sio.c
> > +++ b/arch/alpha/kernel/sys_sio.c
> > @@ -114,6 +114,8 @@ sio_collect_irq_levels(void)
> >  		    (dev->class >> 8 != PCI_CLASS_BRIDGE_PCMCIA))
> >  			continue;
> >  
> > +		pci_assign_irq(dev);
> > +
> >  		if (dev->irq)
> >  			level_bits |= (1 << dev->irq);
> >  	}
> > 
> 
> -- 
> Meelis Roos (mroos@xxxxx)      http://www.cs.ut.ee/~mroos/
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux