On Wed, 3 Jan 2018, Lorenzo Pieralisi wrote: > On Tue, Jan 02, 2018 at 04:32:45PM -0500, Mikulas Patocka wrote: > > Hi > > > > The patch 0e4c2eeb758a91e68b9eaf7a4bee9bd5ed97ff2b ("alpha/PCI: Replace > > pci_fixup_irqs() call with host bridge IRQ mapping hooks") breaks > > networking on Alpha for me. I have an Alpha Avanti server with tulip > > network card. > > > > The patch 0e4c2eeb breaks it so that I get MCE when the network card > > driver is loaded. The patch 814eae59 fixes the MCE, the system boot > > completes, but the network card doesn't receive any interrupts (and soon > > it reports warning about timeout on tx queue). All kernels in the 4.14 > > branch have this bug. > > Can you check if this patch fixes the issue please ? > > I suspect we ought to map IRQs early in this platform so that we are > able to detect how platform code should set them up. > > Thanks, > Lorenzo > > -- >8 -- > diff --git a/arch/alpha/kernel/sys_sio.c b/arch/alpha/kernel/sys_sio.c > index 37bd6d9b8eb9..407ab603e9b1 100644 > --- a/arch/alpha/kernel/sys_sio.c > +++ b/arch/alpha/kernel/sys_sio.c > @@ -114,6 +114,8 @@ sio_collect_irq_levels(void) > (dev->class >> 8 != PCI_CLASS_BRIDGE_PCMCIA)) > continue; > > + pci_assign_irq(dev); > + > if (dev->irq) > level_bits |= (1 << dev->irq); > } This patch fixes the bug. Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html