On Fri, Mar 03, 2017 at 01:27:10PM +0100, Jiri Slaby wrote: > There is code duplicated over all architecture's headers for > futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr, > and comparison of the result. > > Remove this duplication and leave up to the arches only the needed > assembly which is now in arch_futex_atomic_op_inuser. > > Note that s390 removed access_ok check in d12a29703 ("s390/uaccess: > remove pointless access_ok() checks") as access_ok there returns true. > We introduce it back to the helper for the sake of simplicity (it gets > optimized away anyway). > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > --- > arch/s390/include/asm/futex.h | 23 ++++------------- > include/asm-generic/futex.h | 50 +++++++------------------------------ > kernel/futex.c | 36 ++++++++++++++++++++++++++ Looks good to me and still boots on s390. Therefore for the s390 bits: Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html