Re: [PATCH 7/7] alpha: Fix type compatibility warning for marvel_map_irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/07/13 06:03 -0700, Richard Henderson wrote:
> On 07/16/2013 02:12 PM, Phil Carmody wrote:
> > Greetings Richard,
> > 
> > Your
> > 
> > +       struct pci_dev *dev = (struct pci_dev *)dev;
> > 
> > should surely (i.e. I'm nowhere near a compiler or kernel tree 
> > presently) be
> > 
> > +       struct pci_dev *dev = (struct pci_dev *)cdev;
> > 
> > I guess post that, you can have:
> > 
> > Acked-by: Phil Carmody <pc+lkml@xxxxxxxx>
> 
> Ug.  Self-assignment suppressing uninitialized variable warning
> is the stupidest extension evar.

That complaint gets my Ack too!
 
> Good eyes, thanks.

I don't have much to offer, but I never forget how enormously in debt 
I am to those who enabled my shiny new '164 to run linux way way back. 

Phil
-- 
If "law-abiding citizens have nothing to fear" from privacy-invading 
technologies and policies, then law-abiding governments should have
nothing to fear from whistleblowers.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux