On Mon, Nov 1, 2010 at 4:48 AM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> On Mon, 2010-11-01 at 20:28 +1300, Michael Cree wrote:
>> > WARNING: at kernel/softirq.c:138 __local_bh_enable+0xac/0xc0()
>
> That's WARN_ON(!irqs_disabled()), right?
>
> How can that be, you're in the irq_enter path, the hardware should have
> disabled IRQs already, right?
>
>
Code snippet from arch/alpha/kernel/irq.c:handle_irq
irq_enter();
/*
* __do_IRQ() must be called with IPL_MAX. Note that we do not
* explicitly enable interrupts afterwards - some MILO PALcode
* (namely LX164 one) seems to have severe problems with RTI
* at IPL 0.
*/
local_irq_disable();
__do_IRQ(irq);
irq_exit();
So, interrupt seems to be getting disabled after irq_enter and WARN_ON
with this change is coming from irq_enter.
Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
