Re: [PATCH] alpha: fix ALPHA_LEGACY_START_ADDRESS and default to no

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 29, 2010 at 6:25 AM, Michael Cree <mcree@xxxxxxxxxxxx> wrote:
> On 29/10/10 17:22, Matt Turner wrote:
>>
>> Kconfig.debug had ALPHA_LEGACY_START_ADDRESS twice, which seemed to mess
>> the whole thing up so that the only way that you could unselect
>> it was to set ALPHA_GENERIC. That is to say, setting ALPHA_TITAN
>> actually prevented unsetting ALPHA_LEGACY_START_ADDRESS, which is
>> necessary for Titan systems. WTF.
>
> I don't see what the problem is that you are trying to fix.  The current
> Kconfig is set up to automatically turn on ALPHA_LEGACY_START_ADDRESS if you
> select a specific Alpha system for which it is safe to use
> ALPHA_LEGACY_START_ADDRESS and will automatically turn it off if you select
> one of Titan, Marvel or Wildfire.  If you select a Generic system then
> Kconfig enables the ALPHA_LEGACY_START_ADDRESS under the Kernel hacking menu
> so that it can be manually decided whether it should be on or off.
>
> Debian, for example, uses this to build two different generic kernels, one
> with the legacy start address and one without.  Users can choose which
> kernel to use at install time.
>
> If I turn on Titan in the config, then the Legacy Start Address menu item
> disappears, and the .config file is generated with
> ALPHA_LEGACY_START_ADDRESS off.  This appears to me to be the correct
> behaviour.
>
> Cheers
> Michael.

This has been on my todo list for so long that I forgot myself. Turns
out we had trouble building a kernel with LEGACY_START_ADDRESS=n, but
you fixed those errors in commit 3e073367a and I didn't make any
connection.

Does anyone know why ALPHA_LEGACY_START_ADDRESS is in Kconfig twice?
Is this a standard idiom that I don't know about?

I guess there's on point in unsetting this on systems that don't need
it? Does moving the kernel start address back on these systems 5MB
just remove their ability to use that memory?

So, ignore the patch.
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux