Re: [PATCH 5/5] ARM: actions: remove boot_lock and pen_release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 13, 2018 at 1:02 PM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:

> On Thu, Dec 13, 2018 at 11:55:57AM +0000, Russell King wrote:
> > The actions SMP implementation has several issues:
> >
> > 1. pen_release is only ever read and compared to -1, and is defined in
> >    arch/arm/kernel/smp.c to be -1.  This test will always succeed.
> >
> > 2. we are already guaranteed to be single threaded while bringing up a
> >    CPU, so the spinlock makes no sense, remove it.
> >
> > 3. owl_secondary_startup() is not referenced nor defined, the prototype
> >    is redundant, remove it.
> >
> > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>
> Hi Russel,
>
> Is this patch a superset of https://www.spinics.net/lists/arm-kernel/msg694546.html?

Please apply Russell's patch first, I can easily apply my refactorings on
top later.

Yours,
Linus Walleij

_______________________________________________
linux-actions mailing list
linux-actions@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-actions



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux