Hi Hans, On Thu, Mar 4, 2021 at 4:24 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi Rafael, > > While reviewing a new acpi-driver: > https://patchwork.kernel.org/project/platform-driver-x86/patch/CAFysUkSztjJpSjKA92a=3j3Nj7vfQy5TCsiJtNmfjegxLBvFSA@xxxxxxxxxxxxxx/ > > I was wondering what the meaning / use of the acpi_driver.class and > acpi_device_class() fields is and if these should be set to anything > specific ? The latter is passed to acpi_bus_generate_netlink_event() in multiple places and that's the only use of it I'm aware of. The former - I can't recall ATM. > I did a quick grep and most drivers seem to set this to a string describing > the driver / to the driver-name and they seem to set the 2 fields to the > exact same value. But some drivers also use different values for > acpi_driver.class and acpi_device_class() ? I don't generally want acpi_driver to be used at all, if that's possible.