On Fri, Feb 26, 2021 at 11:39 AM Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > > On Fri, Feb 26, 2021 at 11:12:07AM +0200, Andy Shevchenko wrote: > > On Fri, Feb 26, 2021 at 5:42 AM Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > > > > > > Running kernel with ACPI on Lenovo Flex 5G laptop, touchpad is just > > > not working. That's because the GpioInt number of TSC2 node in ACPI > > > table is simply wrong, and the number even exceeds the maximum GPIO > > > lines. As the touchpad works fine with Windows on the same machine, > > > presumably this is something Windows-ism. Although it's obviously > > > a specification violation, believe of that Microsoft will fix this in > > > the near future is not really realistic. > > > > > > It adds the support of overriding broken GPIO number in ACPI table > > > on particular machines, which are matched using DMI info. Such > > > mechanism for fixing up broken firmware and ACPI table is not uncommon > > > in kernel. And hopefully it can be useful for other machines that get > > > broken GPIO number coded in ACPI table. > > > > Thanks for the report and patch. > > > > First of all, have you reported the issue to Lenovo? At least they > > will know that they did wrong. > > Yes, we are reporting this to Lenovo, but to be honest, we are not sure > how much they will care about it, as they are shipping the laptop with > Windows only. > > > Second, is it possible to have somewhere output of `acpidump -o > > flex5g.dat` (the flex5g.dat file)? > > https://raw.githubusercontent.com/aarch64-laptops/build/master/misc/lenovo-flex-5g/dsdt.dsl > > > And as Mika said once to one of mine patches "since you know the > > number ahead there is no need to pollute GPIO ACPI library core with > > this quirk". But in any case I would like to see the ACPI tables > > first. > > Oh, so you had something similar already? Could you point me to the > patch and discussion? Similar, but might be not the same: - patches in the upstream [1] (v3 applied), discussion [2] - new version with some additional fixes [3] [1]: ba8c90c61847 ("gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2") [2]: https://lore.kernel.org/linux-gpio/20200520211916.25727-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u [3]: https://lore.kernel.org/linux-gpio/20210225163320.71267-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u -- With Best Regards, Andy Shevchenko
